Tal Nisan has submitted this change and it was merged. Change subject: core: Move AddVmCommand::checkCpuSockets to Vmvalidator ...................................................................... core: Move AddVmCommand::checkCpuSockets to Vmvalidator The checkCpuSockets is used to validate the cpu socket properties of a VM having it as a static method in AddVmCommand and called from classes not even in the heirarchy of AddVmCommand is plain wrong. The method was thus moved to VmValidator as validateCpuSockets and as a bonus the validationMessages parameter was removed as the error messages are returned through ValidationResult Change-Id: Ic0ab32f7c23aa5358c1e4f06cc0d1efe9712afd4 Signed-off-by: Tal Nisan <tnisan(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java 8 files changed, 46 insertions(+), 62 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0ab32f7c23aa5358c1e4f06cc0d1efe9712afd4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt; Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt; Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;