Allon Mureinik has submitted this change and it was merged. Change subject: core: update SD's setActionMessageParameters ...................................................................... core: update SD's setActionMessageParameters Moved the inclusion of VAR__ACTION__UPDATE in UpdateStorageDomainCommand from canDoAction() to it's rightful place, setActionMessageParameters(). This patch also includes a basic test case that verifies the above change was done correctly. Change-Id: I98d9959cb79e3786e5fb51d50e1e1961e85bf629 Signed-off-by: Allon Mureinik <amureini@redhat.com> Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommandTest.java 2 files changed, 97 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/29808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98d9959cb79e3786e5fb51d50e1e1961e85bf629 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server