Change in ovirt-engine[master]: core: Poll vms stats on relevant statuses

From Roy Golan <rgolan@redhat.com>:
Roy Golan has submitted this change and it was merged. Change subject: core: Poll vms stats on relevant statuses ...................................................................... core: Poll vms stats on relevant statuses Motivation: When a host isn't really active its usless to try to fetch vm stats. Those attempts also add useless reports to handleNetworkException (cause the host is down or there is no connection yet) Change: Stop the code sharing with Host monitoring, and have a relevant set of statuses for stats refresh. Result: Fewer network failures handling, fewer calls to refresh stats. Also on engine startup, the stats poll isn't executed along with the activation of a host, which adds contention on the vdsmanager lock. Change-Id: I9bf1c92593dea587ff0cd887f5f33725729157e6 Signed-off-by: Roy Golan <rgolan@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresherTest.java 3 files changed, 113 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bf1c92593dea587ff0cd887f5f33725729157e6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review