Allon Mureinik has submitted this change and it was merged. Change subject: core: Spy validator directly ...................................................................... core: Spy validator directly Fixed RemoveStorageDomainCommandTest to spy the StorageDomainToPoolRelationValidator it uses directly, instead of mocking its internal DAO calls. This way, RemoveStorageDomainCommandTest actually tests the logic in RemoveStorageDomainCommand instead of testing the internal implementation of the validatiors it uses. Change-Id: I23276e19bae974075f5438b421a4f5b7f37a3d79 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 3 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23276e19bae974075f5438b421a4f5b7f37a3d79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org