Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Use constants for db env keys ...................................................................... packaging: setup: Use constants for db env keys Also verify that all required env keys were passed. Change-Id: I271b1c7c3682a3d0bcc69ae6ea6c9e717ed029d1 Signed-off-by: Yedidyah Bar David <didi@redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 4 files changed, 153 insertions(+), 95 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/39061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I271b1c7c3682a3d0bcc69ae6ea6c9e717ed029d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server