From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. (
https://gerrit.ovirt.org/79335 )
Change subject: core: Allow transferring images for down VMs
......................................................................
core: Allow transferring images for down VMs
Currently, DiskValidator#isDiskAttachedToAnyVm() is used to block
image transfers on all non-floating disks.
This behavior seems to be a bit too naive, as there's no
storage-related not to upload/download an image that happens to have
a database entry that ties it to a VM.
For simplicity's sake, the operation is still blocked for any status
other than DOWN. In the future, we can consider refining this
restriction.
Change-Id: Ia313a451f7642b10b1ee3a46d2ce1bdd1d2fa061
Bug-Url:
https://bugzilla.redhat.com/1414499
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
4 files changed, 24 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit
https://gerrit.ovirt.org/79335
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia313a451f7642b10b1ee3a46d2ce1bdd1d2fa061
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>