Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DataProvider.java cleanup (4/6) ...................................................................... webadmin: DataProvider.java cleanup (4/6) DataProvider is a class which is mostly obsolete, as it contains synchronous calls to the engine, which are not relevant anymore under the GWT platform/infrastructure. The goal is to eliminate this class all-together. In this patch: removing sync getTemplateById and getClusterById, which were used by Edit Pool; PoolListModel.Edit used these methods while filling out the dialog incase the pool is empty. We cannot edit empty pool, hence removed the code dealing with it. Change-Id: Ie7dbd26e10a5d0680a74c5a8dc1ee5cc9461c309 Signed-off-by: Gilad Chaplik <gchaplik@redhat.com> Bug-Url: https://bugzilla.redhat.com/881747 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 2 files changed, 1 insertion(+), 195 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7dbd26e10a5d0680a74c5a8dc1ee5cc9461c309 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com>