Tal Nisan has submitted this change and it was merged. Change subject: core: snapshot disks should be part of the vm disk map only. ...................................................................... core: snapshot disks should be part of the vm disk map only. *Currently the vm populated DiskList should contain only it's actual image disks. The vm attached snapshot disks should be treated as LUN/shareable disks. Regardless to this change, it needs to be inspected if we want to perform the filtering of the disks when loading it from the db or by using ImagesHandler.filterImageDisks, as currently in many flows the filtering is done although VM.getDiskList() contains only the needed disks - therefore in this change I fixed only this part. *When filtering the vm disks/devices - LUN disks should be filtered out as well. Change-Id: I5d18e5d3e321b871f4c7c283c8950fa7645eed5c Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java 3 files changed, 15 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d18e5d3e321b871f4c7c283c8950fa7645eed5c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server