Shahar Havivi has submitted this change and it was merged. Change subject: core: Extract hardcoded strings to constants ...................................................................... core: Extract hardcoded strings to constants This patch pulls hardcoded strings in VmTemplateConditionFieldAutoCompleter to constants. They are used in follow up frontend patch (sorting columns in Template main tab in webadmin application). Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt; Change-Id: Ic5b840c5b44829d8e6e68d4839977e01258076ff Bug-Url: https://bugzilla.redhat.com/1104784 --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java 1 file changed, 64 insertions(+), 50 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/28370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5b840c5b44829d8e6e68d4839977e01258076ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server