Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engin-setup - Drop DB before restore when upgrade fails
(BZ#844341)
......................................................................
packaging: engin-setup - Drop DB before restore when upgrade fails (BZ#844341)
When the DB upgrade fails, the setup tries to restore the backed up DB.
In a specific case, when the upgrade succeeded, but engine-config
execution fails, the DB restore fails, since the DB already exists.
This patch fixes the restore flow, by adding a call to db drop method.
Also, it fixes the reason for the engine-config setup, and always
configure the db connection string and password.
Change-Id: Ic465815c683c0e4241f520960d4acc0dfa59f95a
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/6759
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic465815c683c0e4241f520960d4acc0dfa59f95a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>