Lior Vernia has submitted this change and it was merged. Change subject: engine: Simplify code in UpdateVdsGroupCommand ...................................................................... engine: Simplify code in UpdateVdsGroupCommand Removed a condition that's blocked by canDoAction() - moving a cluster from one (non-null) DC to another. The realization that this operation is blocked also enables to simplify the management network logic, and to always add it and assign it all roles (if it weren't blocked, then the current code wouldn't be correct anyway, because other networks could occupy the roles). Change-Id: I0091d9afb6d4b26c4ba9fb434192a56eda9397e4 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 11 insertions(+), 35 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0091d9afb6d4b26c4ba9fb434192a56eda9397e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server