Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Clean up Editor fields before Model objects ...................................................................... webadmin,userportal: Clean up Editor fields before Model objects This ensures that GWT widgets hooked to UiCommon models have a chance to do their cleanup *before* we destroy the models. This fixes NPEs where a model is already destroyed but a GWT widget attempts to access its properties such as the property change event, see AbstractUiCommandButton#cleanup for example. Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a Bug-Url: https://bugzilla.redhat.com/1389998 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com&gt; Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com&gt; --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorDriver.java 2 files changed, 20 insertions(+), 20 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/65923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;