Allon Mureinik has submitted this change and it was merged. Change subject: core: Inline RolesRowMapper ...................................................................... core: Inline RolesRowMapper Inlined RolesRowMapper in RolesDAODbFacadeImpl as per project conventions. Additionally, this refactoring will allow the RolesRowMapper to benefit from the utilities present in BaseDbFacadeDAO, such as Guid mapping (which will be implemented in a subsequent patch). Change-Id: I3566fcba185f00e0548265714aa13002e4e60bb2 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RolesRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java 2 files changed, 22 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3566fcba185f00e0548265714aa13002e4e60bb2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server