Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Support tab index handling in dialogs ...................................................................... webadmin,userportal: Support tab index handling in dialogs This patch adds the necessary infrastructure to support tab index handling consistently across all application dialogs. In general, tab index values are updated for both dialog content (i.e. widgets contained within popup view directly -or- widgets contained within popup view's content widget [1]) and dialog footer buttons. Tab index values are updated on following occasions: (a) right before the dialog gets revealed in UI, i.e. right after view.edit (before popup reveal) (b) when dialog footer button collection is modified, i.e. right after new button gets added via model (c) upon stopProgress, right before calling focusInput In other words, after this patch, the only thing a dialog class (AbstractModelBoundPopupView subclass -or- content widget [1]) needs to do is to override setTabIndexes method. [1] AbstractModelBoundWidgetPopupView.popupWidget Change-Id: I8b5c7d6a9e7b98c1f5e1fecbaaf193cd862ccb47 Bug-Url: https://bugzilla.redhat.com/1011445 Signed-off-by: Yaniv Bronhaim <ybronhei@redhat.com> Signed-off-by: Ravi Nori <rnori@redhat.com> Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundWidgetPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/FocusableComponentsContainer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractModelBoundPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 11 files changed, 110 insertions(+), 46 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5c7d6a9e7b98c1f5e1fecbaaf193cd862ccb47 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server