From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: engine: Initial size in copy template disk flow
......................................................................
engine: Initial size in copy template disk flow
The 'determineTotalImageInitialSize' method is use to compute the initial
size of a disk image based on the source disk image size, including all
the existing snapshots.
This method calls 'getTotalActualSizeOfDisk' which has a logic based on
the source Storage Domain.
In 'ImagesHandler.determineTotalImageInitialSize', the Storage Domain
passed to 'getTotalActualSizeOfDisk' was the destination SD instead of
the source SD.
This fix is relevant for create VM from template (clone)
Change-Id: I61e42bdb8c70de6bdfcb2b431c8c8ca59fbd665e
Bug-Url:
https://bugzilla.redhat.com/1438691
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/75126
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61e42bdb8c70de6bdfcb2b431c8c8ca59fbd665e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>