Yair Zaslavsky has submitted this change and it was merged. Change subject: bll: LoginBaseCommand cleanup: avoid using object state ...................................................................... bll: LoginBaseCommand cleanup: avoid using object state there is no reason to use object state as helper to avoid parameter passing, per single flow. in some control paths variables were not set. Topic: AAA Change-Id: I6bda9adef3630f8e2f7e4da90838261f20a52ea0 Signed-off-by: Alon Bar-Lev <alonbl@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginAdminUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 2 files changed, 21 insertions(+), 27 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bda9adef3630f8e2f7e4da90838261f20a52ea0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org