Maor Lipchuk has submitted this change and it was merged. Change subject: core:Add connection to DB after connectVds(#815083) ...................................................................... core:Add connection to DB after connectVds(#815083) https://bugzilla.redhat.com/show_bug.cgi?id=815083 When user adds a faulty storage connection it will cause the command to fail, but will leave the connection in the data base. The proposed fix is to add the connection to the DB, only after connect has succeeded at the execute section. Also some unused code is being removed, when we get Vds Id which is empty, rest and GUI should not send an empty vds Id. Change-Id: I6e1387295f4c24f4222b57924ec2f4380411c5f4 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java 1 file changed, 11 insertions(+), 28 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e1387295f4c24f4222b57924ec2f4380411c5f4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Ori Liel <oliel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server