From Piotr Kliczewski <piotr.kliczewski@gmail.com>:

Piotr Kliczewski has submitted this change and it was merged. ( https://gerrit.ovirt.org/79599 ) Change subject: core: set new Pool's images format to COW for 'auto select target' ...................................................................... core: set new Pool's images format to COW for 'auto select target' In case new pool is created based on a template with disk(s) and the 'Auto select target' checkbox (in 'Resource allocation' tab) is set, all Pool VM's images are required to be created with volume format set to the same format as the template's disk (RAW or COW). If RAW format is required for the Pool VM's images, then the Pool creation failed on validation phase. Because of that problem, the 'auto select target' feature isn't working and it is a regression (the regression was added in change id: I6f0f143). This patch fixes it by setting each diskImage.volumeFormat of the Pool's template to COW (or RAW if the disk storage type is CINDER) before creating the Pool's VMs. Change-Id: I9fd04cbcea08125e06c0b9ffb237bcb53057a61a Bug-Url: https://bugzilla.redhat.com/1468301 Signed-off-by: Sharon Gratch <sgratch@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd04cbcea08125e06c0b9ffb237bcb53057a61a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>