Martin Sivák has submitted this change and it was merged. Change subject: upgrade: better checking maintenance mode at engine level ...................................................................... upgrade: better checking maintenance mode at engine level The auto-import of the hosted-engine storage domain from the engine will change its SP so simply checking the list of connected storage pool is safer. vsdcli.list() returns a list of dictionaries, fixing it to avoid 'unhashable type: 'dict''. Bug-Url: https://bugzilla.redhat.com/1295427 Change-Id: I0d0389594c96c54653640b72d9acf4faf71e802a Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 20 insertions(+), 19 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d0389594c96c54653640b72d9acf4faf71e802a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>