Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: vmconsole: major cleanups ...................................................................... packaging: vmconsole: major cleanups triggered by the attempt to use the helper in devenv without entire sequence. found that implementation is way too complex, especially devenv handling which should be minimized, as it just add cost to production maintenance. reduced all devenv specific activities to one plugin. generalized the file creations, so same logic applies both to production and devenv. removed the proprietary "Artifact" pattern as it inconsistent with rest of packaging code, along with some other unneeded helper code. import os register constants module so postinstall will actually work. move conf file out of libexec into share/conf. enable build time customization of vmconsole locations. add ovirt-vmconsole-proxy dependencies, testing if package is available based on user/group is invalid as when package is removed user is kept. if such test is required it should be done using package specific files. the actual test is removed now. update/install vmconsole-proxy package as preparation for future. do not regenerate proxy keys if available so users' known_hosts will not be invalidated when upgrading. also do not regenerate helper and proxy certificates to avoid bloating CA database every upgrade. in future we will need to take care of renew as well, not at this cleanup scope. helper now reads the defaults before the sysconf configuration. improve uninstall text for human. remove port prompt. consistent variable names. remove of unused constants. simplify implementation. probably more. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671 Change-Id: I2c7aef7e1be1efc6015528e8d2ff97596a522d09 Signed-off-by: Alon Bar-Lev <alonbl@redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in R packaging/conf/ovirt-vmconsole-proxy-helper.conf.in M packaging/conf/ovirt-vmconsole-proxy.conf.in M packaging/etc/ovirt-vmconsole-proxy-helper.conf.d/README.in M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt_vmconsole_conf.py.in M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/config.py.in M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py A packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/__init__.py A packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/__init__.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py A packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/system.py 16 files changed, 435 insertions(+), 597 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c7aef7e1be1efc6015528e8d2ff97596a522d09 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Francesco Romani <fromani@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: automation@ovirt.org