Tal Nisan has submitted this change and it was merged. Change subject: core: Move snapshot ID fields from VmDisk params to AttachDeatch params ...................................................................... core: Move snapshot ID fields from VmDisk params to AttachDeatch params The snapshot ID is only used in the attach/detach commands, it has nothing to do with the general disk to VM parameters Change-Id: Id25350af6fed50bc91b789bc739eeda77c183144 Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDetachVmDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmDiskOperationParameterBase.java 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25350af6fed50bc91b789bc739eeda77c183144 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>