Omer Frenkel has submitted this change and it was merged. Change subject: core: Update roles.allow_viewing_children properly ...................................................................... core: Update roles.allow_viewing_children properly This patch contains the logic for updating roles.allow_viewing_children: If a role contains at least one action group that allows viewing children then it too is allows viewing children. This patch contains all the (relevant) places roles are modified: 1. An upgarade script to initialize the property properly 2. When a new action group is attached to a role 3. When an action group is detached from a role 4. When a role is created without action groups 5. When a role is created with action groups Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- A backend/manager/dbscripts/upgrade/03_01_1130_update_role_allows_viewing_children_column.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractRolesCommandTestBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommandTest.java 9 files changed, 262 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;