Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Fix brick validation during Add Bricks ...................................................................... engine: Fix brick validation during Add Bricks While adding a new brick(s) to a volume, server_id and brick_directory combination will be validated against the entries in the gluster_volume_bricks table. If there are any existing entries found for the server:brick_dir, an error message will be thrown to the user. Introduced a new procedure to get a brick entity based on server_id and brick directory. Also an error message will be thrown if there any duplicate bricks found. Change-Id: I83ec15a183d81a274388c313006208d439809548 Bug-Url: https://bugzilla.redhat.com/856109 Signed-off-by: Kanagaraj M <kmayilsa@redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 9 files changed, 89 insertions(+), 37 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/12612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83ec15a183d81a274388c313006208d439809548 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal@redhat.com>