From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Read correctly attributes with enum values
......................................................................
Read correctly attributes with enum values
A recent patch introduced a mechanism to ignore incorrect values of enum
types. That patch also introduced a regresion for attributes of enum
types that have a name different to their type name. For example, the
'vm.migration.auto_converge' attribute is of type 'InheritableBoolean',
not of type 'AutoConverge' as assumed by the code generator. This patch
fixes that issue.
Change-Id: Ie0e67fd4ecf6e38b9e23c6b6cd929db1836adafd
Bug-Url:
https://bugzilla.redhat.com/1428642
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M sdk/lib/ovirtsdk4/reader.rb
M sdk/spec/vm_reader_spec.rb
3 files changed, 63 insertions(+), 16 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/73505
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0e67fd4ecf6e38b9e23c6b6cd929db1836adafd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>