Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Don't use console for debug log ...................................................................... tools: Don't use console for debug log Currently we use a console appender for the debug log level of the engine-config tool, this means that the debug messages are mixed with the regular output of the tool, and that confuses its users, including engine-setup and engine-manage-domains. This change introduces a new ToolConsole class for the tools. This class centralizes all input and output to the console and sends all the text to the log as well. The engine-config tool uses this new class for regular input and output. This change also removes the console appender from the log4j configuration and changes the default log level to DEBUG so that debug messages will be sent to the log as they used to be. Change-Id: I556e20f6333e22faeb7d212767ebefb99edce54e Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/tools/src/main/conf/engine-config-log4j.xml.in M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/ToolConsole.java 8 files changed, 268 insertions(+), 101 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556e20f6333e22faeb7d212767ebefb99edce54e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>