Tal Nisan has submitted this change and it was merged. Change subject: engine: Prevents duplicates parameters in multiple actions ...................................................................... engine: Prevents duplicates parameters in multiple actions The multiple action runner api serves as a method for invoking multiple actions in a single call to the engine. However, it turns out that due to a mysterious bug, in few flows the UI provides the same parameter more than once which might lead to an unexpected behavior (i.e. infinite locked vm). By replacing the parameters collection type to set we prevent that from happen, and each parameter class will implement its own euqals() and hasCode() methods to enforce the uniqueness. Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Bug-Url: https://bugzilla.redhat.com/1174815 Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java 3 files changed, 20 insertions(+), 12 deletions(-) Approvals: Arik Hadas: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server