Daniel Erez has submitted this change and it was merged.
Change subject: core: register RemoveSnapshotCommandCallback only for a running VM
......................................................................
core: register RemoveSnapshotCommandCallback only for a running VM
RemoveSnapshotCommand - registering RemoveSnapshotCommandCallback
for a non running VM is redundant and lead to an exception as described
in the bug. Hence, adding the callback only for a running VM.
Change-Id: I1f2440a6860dbdd5ece5c3979c710e90ccaa3929
Bug-Url:
https://bugzilla.redhat.com/1148710
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
3 files changed, 18 insertions(+), 3 deletions(-)
Approvals:
Greg Padgett: Looks good to me, but someone else must approve
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/33709
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f2440a6860dbdd5ece5c3979c710e90ccaa3929
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server