Liron Aravot has submitted this change and it was merged. Change subject: core: BaseImagesCommand - isDataOperationsByHSM() logic ...................................................................... core: BaseImagesCommand - isDataOperationsByHSM() logic SDM flows would be implemented in such a way that in case that the host which is performing the operation will go non responsive we'll be able to poll using a different host by check the actual entity on the storage. In order to do that on oVirt images, we intend to use the volume leases so we can determine if the operation on the volume was ended or is still running. Export domains and local storage domains doesn't support volume leases therefore if the performing host goes non responsive there's no way to track the operation, therefore the SDM verbs aren't supposed to support those. This patches update isDataOperationsByHSM() to return false if the domain isn't data domain or if it is a local domain. Change-Id: I7826ef8317a667d2a563a702a5e6931f382f638d Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7826ef8317a667d2a563a702a5e6931f382f638d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>