From Tal Nisan <tnisan@redhat.com>:

Tal Nisan has submitted this change and it was merged. Change subject: core: validate usb unmanaged devices in runVmCommand ...................................................................... core: validate usb unmanaged devices in runVmCommand In case the Usb policy is set to DISABLED for an "old" VM (<= 3.6) with an old USB configuration (i.e. more then one USB unmanaged controllers) and that VM is restarted/rerun/rebooted in engine 4.1: an error is thrown with host=UNKNOWN (null) since it is thrown in runVmCommand->initVm()->updateVmDevicesOnRun() phase while there is still no host scheduled for this VM. This scenario is unique since no manual VM configuration update validation is involved and the user won't know about that prior to restrating/re-running an old VM in new engine. To fix that we add the old USB configuration validation to runVmCommand()->validate() method instead of catching it later on in initVM() method. Change-Id: I8876a17d90f5a70bc7bc05814875cbbb40601be3 Bug-Url: https://bugzilla.redhat.com/1435579 Signed-off-by: Sharon Gratch <sgratch@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 41 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8876a17d90f5a70bc7bc05814875cbbb40601be3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>