Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove redundant threshold call ...................................................................... core: Remove redundant threshold call While adding storage domains to a map in ImagesHandler.fillImagesMapBasedOnTemplate(), there's a threshold check. This check is redundant and buggy here. Redundant because there are storage allocation checks in the system now, which should be called in due time. Buggy, since in case the threshold has been met, the threshold validation fails, but with no error at the time of failure. The map is not filled correctly, and we get another, unrelated error. This patch removes the threshold validation and relies on it being called when it should. Change-Id: Ifb4357a19bc51ae5feb3c8e79ff36f3adacc327f Bug-Url: https://bugzilla.redhat.com/tbd Related-To: https://bugzilla.redhat.com/1179690 Signed-off-by: Vered Volansky <vvolansk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 4 files changed, 7 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/37213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb4357a19bc51ae5feb3c8e79ff36f3adacc327f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server