Gilad Chaplik has submitted this change and it was merged.
Change subject: frontend: ConcurrentModificationException in AdElementListModel
......................................................................
frontend: ConcurrentModificationException in AdElementListModel
The exception occured in the populateRoles method when user is adding
permissions to the VM in permissions subtab. The problem is introduced by
refactoring in 05c06da3 and is only visible in gwt-debug console.
The problem was caused by removing items from the list in the for-each loop.
Fixed by introducing a copy of the modified list (to avoid modifying the
collection passed in the argument).
Change-Id: Id845725507782162c14f6e7b214f65cc6060f59b
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/13345
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id845725507782162c14f6e7b214f65cc6060f59b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: noam slomianko <drekmastermind(a)gmail.com>
Gerrit-Reviewer: noam slomianko <nslomian(a)redhat.com>