Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StreamReaderCompat ...................................................................... core: Remove StreamReaderCompat This patch removes the deprecate class StreamReaderCompat and its ancestor, TextReaderCompat. StreamReaderCompat was only used in a single place, GetCACertificateQuery, which was rewritten to use FileUtil and TextReaderCompat was not used anywhere (besides both classes' unit tests, that is). This patch rewrites the single usage of StreamReaderCompat so it is no longer needed, and removes the two useless classes and their unit tests. Change-Id: Id5a072fbcdfabb3291fd3ecd83c4c722a5a3813a Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/StreamReaderCompat.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TextReaderCompat.java D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StreamReaderCompatTest.java D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/TextReaderCompatTest.java 5 files changed, 4 insertions(+), 155 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a072fbcdfabb3291fd3ecd83c4c722a5a3813a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>