Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Changed semantics of NULL_OPERATION in Setup Networks ...................................................................... webadmin: Changed semantics of NULL_OPERATION in Setup Networks Changed the semantics of a generic NULL_OPERATION to actually represent a NO-OP. When a generic NULL_OPERATION is performed no message appears in the header of the dialog, thus promoting a feel that no operation is performed (rather than an operation is attempted and failed). Also removed a check whether an interface being dragged is already bonded; when dragging an interface that's part of a bond it is the bond that's dragged anyway, so this check can't return true. Change-Id: Ie5188b3c6ca5838f6e0d6bb184e554970b6f0c0f Bug-Url: https://bugzilla.redhat.com/906313 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java 5 files changed, 10 insertions(+), 13 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5188b3c6ca5838f6e0d6bb184e554970b6f0c0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server