Vojtech Szocs has submitted this change and it was merged.
Change subject: core: Locale docs servlet.
......................................................................
core: Locale docs servlet.
- Added DocsServlet to automatically redirect users if
the servlet cannot find the documentation in the users locale.
- Added a check to make sure we are being passed a valid locale.
- Added an intermediate page to inform the user that the
documentation in their locale does not exist and how to install
it.
- Added unit tests for all used classes.
Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5
Bug-Url:
https://bugzilla.redhat.com/885823
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/root/pom.xml
A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java
M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java
A backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/DocsServletTest.java
A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/FileServletTest.java
A
backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/en-US/index.html
A
backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/fr/index.html
A
backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/index.html
A
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocaleUtils.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ServletUtils.java
A
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/LocaleUtilsTest.java
A
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ServletUtilsTest.java
A backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/zerosize
15 files changed, 1,130 insertions(+), 70 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/10065
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>