Michael Kublin has submitted this change and it was merged. Change subject: core: Storage domains failover never runs when all domains in problem ...................................................................... core: Storage domains failover never runs when all domains in problem When blocking connections to all storage domains of pool at once, reconstruct will never success as we don't have a working connection to any domain, each running reconstruct will clear the domain timers, meaning that the domains will never move to be inactive. Basically the behaviour after this patch will be- Successful reconstruct : clear jobs, problematic data and all events from the queue. Failed reconstruct: leave jobs, 'problematic' domains and vds data, leave DOMAINFAILOVER/VDSCLEARCACHE events in the queue. This patch adds the following changes: *Event with the type of DOMAINFAILOVER/VDSCLEARCACHE should be added to the queue when reconstruct runs and also stay in the queue after unsuccessful reconstruct. *MarkPoolInReconstructMode which clears the timers and delete the 'problematic' data should be executed only if the reconstruct command succeeded so that the domains will be able to move to inactive state, I've removed also the no longer parameters and enum classes. Change-Id: Ib1a45098dc4eb2607dd12dabf3c0d526e8bebca7 Bug-Url: https://bugzilla.redhat.com/912054 Signed-off-by: Liron Aravot <laravot(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MarkPoolInReconstructModeVDSCommandParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMarkAction.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MarkPoolInReconstructModeVDSCommand.java 5 files changed, 34 insertions(+), 77 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1a45098dc4eb2607dd12dabf3c0d526e8bebca7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt; Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com&gt; Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com&gt;