Alona Kaplan has submitted this change and it was merged. Change subject: engine: Reuse VmInfoBuilder to add profile data to nic in VDS commands ...................................................................... engine: Reuse VmInfoBuilder to add profile data to nic in VDS commands HotPlugNicVDSCommand, UpdateVmInterfaceVDSCommand and VmInfoBuider has the same logic for adding the profile data to the nic on the struct sent to vdsm. This patch adds a static method to VmInfoBuilder- addProfileDataToNic(..). Using this method also fixes some bugs- - Makes VmInfoBuilder work with VmNic instead of VmNetworkInterface. - VmInfoBuilder didn't use the vnic_profile to get the network name and port mirroring. - UpdateVmInterfaceVDSCommand didn't add the vm.getRuntimeDeviceCustomProperties().get(vmDevice) to the custom properties that were sent to the host. Change-Id: I234bb2854a5d2d8bdb97dd7d76d34167016c87e7 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com&gt; --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVmInterfaceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 39 insertions(+), 59 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I234bb2854a5d2d8bdb97dd7d76d34167016c87e7 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com&gt;