Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: reimplemented engine_firewalld
......................................................................
packaging: reimplemented engine_firewalld
Reimplemented using the firewall-cmd command
instead of the python API, avoiding issues with dbus.
The firewall-cmd command will be used also in otopi based
rewrite of the engine-setup command.
(cherry picked from commit a5d9a59c043709f9515b287f45cae0cdd3996183)
Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36
Bug-Url:
https://bugzilla.redhat.com/924071
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine_firewalld.py
2 files changed, 42 insertions(+), 13 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified
Ofer Schreiber: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/13609
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>