Maor Lipchuk has submitted this change and it was merged. Change subject: core: Re-ordering validations at create snapshot command. ...................................................................... core: Re-ordering validations at create snapshot command. Some validations in the create snapshot command were only executed if the VM had disks, that caused the command to skip validations for diskless VM. The fix was to move the relevant validations to be executed regardless to the VM disks. Also added a test for create snapshot from VM. Bug-Url: https://bugzilla.redhat.com/903245 Change-Id: I58bfc73383ce5ca06bf670a8f63b5563da9caa02 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 2 files changed, 306 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58bfc73383ce5ca06bf670a8f63b5563da9caa02 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>