Mike Kolesnik has submitted this change and it was merged. Change subject: core: Remove Network Name in Import (#844396) ...................................................................... core: Remove Network Name in Import (#844396) https://bugzilla.redhat.com/844396 1. Changes the way VmInterfaceManager validates a network. The purpose is to allow better use of the method from ImportVmCommand and from ImportVmTemplateCommand. 2. Changes the logging of ImportVmCommand and ImportVmTemplateCommand to behave the same. 3. Makes sure the Network name is removed from Nic in case the Network name was found to be invalid. Also, it separates the audit log into two - one for ImportVm and the other for ImportVmTemplate. 4. Changes the wording of the audit log to be more accurate. Signed-off-by: Muli Salem <msalem@redhat.com> Change-Id: I1c0e2258d1523c99ef095a3e07947835ff0c5da2 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 8 files changed, 126 insertions(+), 60 deletions(-) Approvals: Muli Salem: Verified Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c0e2258d1523c99ef095a3e07947835ff0c5da2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem@redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Muli Salem <msalem@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server