Roy Golan has submitted this change and it was merged. Change subject: engine: Refactoring numa node dao classes ...................................................................... engine: Refactoring numa node dao classes Created interafce NumaNodeDao and abstract class NumaNodeDaoImpl, so VmNumaNodeDaoImpl does not extend VdsNumaNodeDaoImpl. It is now possible to inject them using type resolution only. Change-Id: I614ea5757080cdbbd02b8923cbcdd327dd0c54a6 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NumaNodeDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NumaNodeDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java 10 files changed, 212 insertions(+), 190 deletions(-) Approvals: Roy Golan: Looks good to me, approved; Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/47989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I614ea5757080cdbbd02b8923cbcdd327dd0c54a6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: automation@ovirt.org