From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Make GlusterTasksSyncJobTest a unit test
......................................................................
core: Make GlusterTasksSyncJobTest a unit test
GlusterTasksSyncJobTest creates a GlusterTasksSyncJob instance and a
GlusterTaskUtils that's mocked into it.
It then proceeds to test not just GlusterTasksSyncJob's behavior, but
also the inner workings of the GlusterTaskUtils, thus, it is not really
a UNIT test, and maintaining it may become exceedingly complicated when
these inner workings are changed (e.g., if the dependencies of the
GlusterTaskUtils are injected, as is the intention later on in this
patch series).
This patch replaces the real instance of the GlusterTaskUtils with a
mocked one, thus making GlusterTasksSyncJobTest a true unit test.
Change-Id: I53b6a3ed260e57619bad5020a804bb8a93420e47
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java
1 file changed, 6 insertions(+), 40 deletions(-)
Approvals:
Denis Chaplygin: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/72580
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53b6a3ed260e57619bad5020a804bb8a93420e47
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>