Michael Kublin has submitted this change and it was merged. Change subject: core: Cleanup RoleDAO and its test ...................................................................... core: Cleanup RoleDAO and its test 1. Replaced new RolesRowMapper() calls with a static instance, as per http://ovirt.org/wiki/Backend_Coding_Standards. 2. Replaced * imports with FCQN imports. 3. Fixed javadoc typos. Change-Id: I37ead9c07904302204b99d919c27061fff4f0b8f Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RolesRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java 3 files changed, 14 insertions(+), 10 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37ead9c07904302204b99d919c27061fff4f0b8f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>