Greg Padgett has submitted this change and it was merged. Change subject: agent, lib: agent compatibility with metadata updates ...................................................................... agent, lib: agent compatibility with metadata updates When the metadata version changes, both old and new agents should recognize this and behave appropriately. The desired behavior is described in this comment from constants.py.in: The range of valid metadata versions for this host is from METADATA_PARSE_VERSION <= version <= METADATA_FEATURE_VERSION. If an incompatible change is made to the metadata, both the parse and feature versions should be raised beyond the current feature version. This will ensure that a) the old agent will recognize that it has been superseded and shut down the vm, and b) the newer agents will ignore the older agents' reported scores, thus assuming control of the vm. Change-Id: I2357ce26aeb20439dec161c7b8ee46d94a4b3e3d Bug-Url: https://bugzilla.redhat.com/1036710 Signed-off-by: Greg Padgett <gpadgett@redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/lib/exceptions.py M ovirt_hosted_engine_ha/lib/metadata.py 4 files changed, 71 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2357ce26aeb20439dec161c7b8ee46d94a4b3e3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server