Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Introduction and usage of CustomPropertiesValueHelper ...................................................................... tools: Introduction and usage of CustomPropertiesValueHelper The following patch introduces the CustomPropertiesValueHelper to be used with UserdefinedVmProperties. In order to provide a more accurate description, validate method is changed to return a ValidationResult object that contains a descriptive message. engine-config.properties is changed accordingly. Bug-Id: https://bugzilla.redhat.com/ 878964 Change-Id: Ieffbc359880e87a7159906579a18b2e5c63bd718 Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java A backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java A backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/ValidationResult.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/ValueHelper.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 11 files changed, 107 insertions(+), 25 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieffbc359880e87a7159906579a18b2e5c63bd718 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>