Roy Golan has submitted this change and it was merged. Change subject: core: VM monitoring - no need to handle exception ...................................................................... core: VM monitoring - no need to handle exception Execption handling isn't the responsibility of this class rather its Host Monitoring task. - fetchVMs is now void method - VDSProtocolException was never used in the code next: separate the VM fetching strategy responsibility Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068 Change-Id: I6f037813b52d63c45c97c44e3e6074c009dd5b9a Signed-off-by: Roy Golan <rgolan@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSProtocolException.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java 3 files changed, 38 insertions(+), 84 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f037813b52d63c45c97c44e3e6074c009dd5b9a Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org