Eli Mesika has submitted this change and it was merged. Change subject: core: Upgrade from 3.1 to 3.2 fails : upgrade... ...................................................................... core: Upgrade from 3.1 to 3.2 fails : upgrade... Upgrade from 3.1 to 3.2 fails : upgrade 03_01_1470_add_smartcard.sql is not being installed This bug is a result of the following: 1) 03_02_0080_add_user_vm_manager_to_vm_power_users.sql was originally named 03_01_1470_add_user_vm_manager_to_vm_power_users.sql 2) some installations already installed it as 03_01_1470 3)03_01_1470_add_user_vm_manager_to_vm_power_users.sql was renamed to 03_02_0080_add_user_vm_manager_to_vm_power_users.sql 4)03_01_1470_add_smartcard.sql was added 5)upon upgrade 03_01_1470_add_smartcard.sql will not installed because 03_01_1470_add_user_vm_manager_to_vm_power_users.sql was already installed Solution is to copy 03_01_1470_add_smartcard.sql to 03_01_1540_fix_add_smartcard.sql This will solve the problem in all the possible cases 1) Clean install : only 03_01_1470_add_smartcard.sql will be installed 03_01_1540_fix_add_smartcard.sql will be skipped since it has an identical md5 2) Upgrade on a DB that already has 03_01_1470_add_user_vm_manager_to_vm_power_users.sql: In this case 03_01_1540_fix_add_smartcard.sql will be installed and 03_02_0080_add_user_vm_manager_to_vm_power_users.sql will be skipped since it has the same md5 as the installed one. 3) upgrade on a DB that has the correct 03_01_1470_add_smartcard.sql : In this case 03_01_1540_fix_add_smartcard.sql will be skipped since it has the same md5 as the original Change-Id: I5e827d5b684459703315c5ecc46c1142a58d8e84 Signed-off-by: Eli Mesika <emesika@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903604 --- A backend/manager/dbscripts/upgrade/03_01_1540_add_smartcard.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e827d5b684459703315c5ecc46c1142a58d8e84 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>