Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove comparators' empty default ctors
......................................................................
core: Remove comparators' empty default ctors
Removed empty implementation of the default constructor throughout the
comparators package.
These constructors have no added value, and just clatter up the code.
Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java
4 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit
http://gerrit.ovirt.org/14415
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>