Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Accept directory user in AddUser command ...................................................................... core: Accept directory user in AddUser command Currently the parameter class for the AddUser command has fields for VdcUser, LdapUser and LdapGroup, but the command only works correctly if it gets a VdcUser or a LdapGroup, it will fail if only given a LdapUser. In the future we wan't to be able to use only directory users and groups (althought groups should go to a different command) and not VdcUser. To simplify this future change this patch modifies the command so that it will work correctly if only given the LdapUser. Change-Id: I5caee3a8e295a13c52ed7ea243b1fc25b7603da6 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5caee3a8e295a13c52ed7ea243b1fc25b7603da6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server