Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: CidrValidation refactor ...................................................................... webadmin: CidrValidation refactor Refactoring CidrValidation and its corresponding test. The refacor will make the test atomic. Will later be refactor again to support cidrValidator injection. Change-Id: I062320b351df6933a45b730ac4ce3b54a7881706 Bug-Url: https://bugzilla.redhat.com/1269481 Signed-off-by: Eliraz Levi <elevi@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java 2 files changed, 79 insertions(+), 86 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I062320b351df6933a45b730ac4ce3b54a7881706 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>