Muli Salem has submitted this change and it was merged. Change subject: core: Do Not Allow Same Mac Address (#845837) ...................................................................... core: Do Not Allow Same Mac Address (#845837) https://bugzilla.redhat.com/845837 This patch removes the freeing of Mac addresses from the MacPool in the canDoAction of UpdateVmInterface and AddVmInterface. The reason is that this enabled adding two VmInterfaces with the same Mac address. Signed-off-by: Muli Salem <msalem@redhat.com> Change-Id: I3cfcf0c15bc494f1debd4bdd3e15bd396b179323 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java 2 files changed, 3 insertions(+), 7 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cfcf0c15bc494f1debd4bdd3e15bd396b179323 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Muli Salem <msalem@redhat.com>